tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

selftests: mptcp: lib: fix shellcheck errors

It looks like we missed these two errors recently:

- SC2068: Double quote array expansions to avoid re-splitting elements.
- SC2145: Argument mixes string and array. Use * or separate argument.

Two simple fixes, it is not supposed to change the behaviour as the
variable names should not have any spaces in their names. Still, better
to fix them to easily spot new issues.

Fixes: f265d3119a29 ("selftests: mptcp: lib: use setup/cleanup_ns helpers")
Signed-off-by: Matthieu Baerts (NGI0) <matttbe@kernel.org>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20240712-upstream-net-next-20240712-selftests-mptcp-fix-shellcheck-v1-1-1cb7180db40a@kernel.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

authored by

Matthieu Baerts (NGI0) and committed by
Jakub Kicinski 464b99e7 22767eec

+2 -2
+2 -2
tools/testing/selftests/net/mptcp/mptcp_lib.sh
··· 428 428 } 429 429 430 430 mptcp_lib_ns_init() { 431 - if ! setup_ns ${@}; then 432 - mptcp_lib_pr_fail "Failed to setup namespace ${@}" 431 + if ! setup_ns "${@}"; then 432 + mptcp_lib_pr_fail "Failed to setup namespaces ${*}" 433 433 exit ${KSFT_FAIL} 434 434 fi 435 435