tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Input: ir-keytable - fix uninitialized variable warning

We were forgetting to set up proper return value in success path causing
ir_getkeycode() to fail intermittently:

drivers/media/IR/ir-keytable.c: In function 'ir_getkeycode':
drivers/media/IR/ir-keytable.c:363: warning: 'retval' may be used
uninitialized in this function

Reported-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

authored by

Dmitry Torokhov and committed by
Linus Torvalds 47c5ba53 50440c6d

+2
+2
drivers/media/IR/ir-keytable.c
··· 389 389 ke->len = sizeof(entry->scancode); 390 390 memcpy(ke->scancode, &entry->scancode, sizeof(entry->scancode)); 391 391 392 + retval = 0; 393 + 392 394 out: 393 395 spin_unlock_irqrestore(&rc_tab->lock, flags); 394 396 return retval;