tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/i915: replace use of system_wq with system_percpu_wq in the documentation

Currently if a user enqueue a work item using schedule_delayed_work() the
used wq is "system_wq" (per-cpu wq) while queue_delayed_work() use
WORK_CPU_UNBOUND (used when a cpu is not specified). The same applies to
schedule_work() that is using system_wq and queue_work(), that makes use
again of WORK_CPU_UNBOUND.

This lack of consistency cannot be addressed without refactoring the API.

system_wq should be the per-cpu workqueue, yet in this name nothing makes
that clear, so replace system_wq with system_percpu_wq.

This patch continues the effort to refactor worqueue APIs, which has
begun with the change introducing new workqueues:

commit 128ea9f6ccfb ("workqueue: Add system_percpu_wq and system_dfl_wq")

The old wq (system_wq) will be kept for a few release cycles.

This change only update the documentation of drm/i915.

Suggested-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
Reviewed-by: Krzysztof Karas <krzysztof.karas@intel.com>
Link: https://patch.msgid.link/20251104100032.61525-3-marco.crivellari@suse.com
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

authored by

Marco Crivellari and committed by
Rodrigo Vivi 4fb289d3 36ed3648

+2 -2
+1 -1
drivers/gpu/drm/i915/i915_driver.c
··· 151 151 /* 152 152 * The unordered i915 workqueue should be used for all work 153 153 * scheduling that do not require running in order, which used 154 - * to be scheduled on the system_wq before moving to a driver 154 + * to be scheduled on the system_percpu_wq before moving to a driver 155 155 * instance due deprecation of flush_scheduled_work(). 156 156 */ 157 157 dev_priv->unordered_wq = alloc_workqueue("i915-unordered", 0, 0);
+1 -1
drivers/gpu/drm/i915/i915_drv.h
··· 249 249 * 250 250 * This workqueue should be used for all unordered work 251 251 * scheduling within i915, which used to be scheduled on the 252 - * system_wq before moving to a driver instance due 252 + * system_percpu_wq before moving to a driver instance due 253 253 * deprecation of flush_scheduled_work(). 254 254 */ 255 255 struct workqueue_struct *unordered_wq;