tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

keys: drop shadowing dead prototype

The global variable pkcs7 does not exist.
Drop the variable declaration, but keep the struct prototype needed for
is_key_on_revocation_list().

Reported by clang:

./include/keys/system_keyring.h:104:67: warning: declaration shadows a variable in the global scope [-Wshadow]
104 | static inline int is_key_on_revocation_list(struct pkcs7_message *pkcs7)
| ^
./include/keys/system_keyring.h:76:30: note: previous declaration is here
76 | extern struct pkcs7_message *pkcs7;
| ^

Fixes: 56c5812623f9 ("certs: Add EFI_CERT_X509_GUID support for dbx entries")
Signed-off-by: Christian Göttsche <cgzones@googlemail.com>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>

authored by

Christian Göttsche and committed by
Jarkko Sakkinen 5f56d41a 95ec54a4

+1 -1
+1 -1
include/keys/system_keyring.h
··· 73 73 } 74 74 #endif 75 75 76 - extern struct pkcs7_message *pkcs7; 77 76 #ifdef CONFIG_SYSTEM_BLACKLIST_KEYRING 78 77 extern int mark_hash_blacklisted(const u8 *hash, size_t hash_len, 79 78 enum blacklist_hash_type hash_type); ··· 92 93 } 93 94 #endif 94 95 96 + struct pkcs7_message; 95 97 #ifdef CONFIG_SYSTEM_REVOCATION_LIST 96 98 extern int add_key_to_revocation_list(const char *data, size_t size); 97 99 extern int is_key_on_revocation_list(struct pkcs7_message *pkcs7);