Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/i915/de: Introduce intel_de.c and move intel_de_{read,write}8() there
intel_de_{read,write}8() aren't performance critical so having them
as static inline is pointless. Introduce intel_de.c and move the
implementation there.
Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patch.msgid.link/20260313111028.25159-2-ville.syrjala@linux.intel.com
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
+28
-19
+1
drivers/gpu/drm/i915/Makefile
+1
drivers/gpu/drm/i915/Makefile
+23
drivers/gpu/drm/i915/display/intel_de.c
+23
drivers/gpu/drm/i915/display/intel_de.c
···
1
+
// SPDX-License-Identifier: MIT
2
+
/*
3
+
* Copyright © 2026 Intel Corporation
4
+
*/
5
+
6
+
#include <drm/drm_print.h>
7
+
8
+
#include "intel_de.h"
9
+
10
+
u8 intel_de_read8(struct intel_display *display, i915_reg_t reg)
11
+
{
12
+
/* this is only used on VGA registers (possible on pre-g4x) */
13
+
drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 5 || display->platform.g4x);
14
+
15
+
return intel_uncore_read8(__to_uncore(display), reg);
16
+
}
17
+
18
+
void intel_de_write8(struct intel_display *display, i915_reg_t reg, u8 val)
19
+
{
20
+
drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 5 || display->platform.g4x);
21
+
22
+
intel_uncore_write8(__to_uncore(display), reg, val);
23
+
}
+3
-19
drivers/gpu/drm/i915/display/intel_de.h
+3
-19
drivers/gpu/drm/i915/display/intel_de.h
···
6
6
#ifndef __INTEL_DE_H__
7
7
#define __INTEL_DE_H__
8
8
9
-
#include <drm/drm_print.h>
10
-
11
9
#include "intel_display_core.h"
12
10
#include "intel_dmc_wl.h"
13
11
#include "intel_dsb.h"
···
16
18
{
17
19
return to_intel_uncore(display->drm);
18
20
}
21
+
22
+
u8 intel_de_read8(struct intel_display *display, i915_reg_t reg);
23
+
void intel_de_write8(struct intel_display *display, i915_reg_t reg, u8 val);
19
24
20
25
static inline u32
21
26
intel_de_read(struct intel_display *display, i915_reg_t reg)
···
32
31
intel_dmc_wl_put(display, reg);
33
32
34
33
return val;
35
-
}
36
-
37
-
static inline u8
38
-
intel_de_read8(struct intel_display *display, i915_reg_t reg)
39
-
{
40
-
/* this is only used on VGA registers (possible on pre-g4x) */
41
-
drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 5 || display->platform.g4x);
42
-
43
-
return intel_uncore_read8(__to_uncore(display), reg);
44
-
}
45
-
46
-
static inline void
47
-
intel_de_write8(struct intel_display *display, i915_reg_t reg, u8 val)
48
-
{
49
-
drm_WARN_ON(display->drm, DISPLAY_VER(display) >= 5 || display->platform.g4x);
50
-
51
-
intel_uncore_write8(__to_uncore(display), reg, val);
52
34
}
53
35
54
36
static inline u64
+1
drivers/gpu/drm/xe/Makefile
+1
drivers/gpu/drm/xe/Makefile