tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

platform/surface: aggregator: Fix event disable function

Disabling events silently fails due to the wrong command ID being used.
Instead of the command ID for the disable call, the command ID for the
enable call was being used. This causes the disable call to enable the
event instead. As the event is already enabled when we call this
function, the EC silently drops this command and does nothing.

Use the correct command ID for disabling the event to fix this.

Fixes: c167b9c7e3d6 ("platform/surface: Add Surface Aggregator subsystem")
Signed-off-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20210603000636.568846-1-luzmaximilian@gmail.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

authored by

Maximilian Luz and committed by
Hans de Goede 6cbaee2e 28e36712

+1 -1
+1 -1
drivers/platform/surface/aggregator/controller.c
··· 1907 1907 { 1908 1908 int status; 1909 1909 1910 - status = __ssam_ssh_event_request(ctrl, reg, reg.cid_enable, id, flags); 1910 + status = __ssam_ssh_event_request(ctrl, reg, reg.cid_disable, id, flags); 1911 1911 1912 1912 if (status < 0 && status != -EINVAL) { 1913 1913 ssam_err(ctrl,