Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
phy: freescale: imx8m-pcie: Simplify with dev_err_probe()
Error handling in probe() can be a bit simpler with dev_err_probe().
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Link: https://lore.kernel.org/r/20250429090152.1094243-1-alexander.stein@ew.tq-group.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
authored by
Alexander Stein
and committed by
Vinod Koul
74c2524a
6d0e2ada
+9
-12
+9
-12
drivers/phy/freescale/phy-fsl-imx8m-pcie.c
+9
-12
drivers/phy/freescale/phy-fsl-imx8m-pcie.c
···
238
238
imx8_phy->clkreq_unused = false;
239
239
240
240
imx8_phy->clk = devm_clk_get(dev, "ref");
241
-
if (IS_ERR(imx8_phy->clk)) {
242
-
dev_err(dev, "failed to get imx pcie phy clock\n");
243
-
return PTR_ERR(imx8_phy->clk);
244
-
}
241
+
if (IS_ERR(imx8_phy->clk))
242
+
return dev_err_probe(dev, PTR_ERR(imx8_phy->clk),
243
+
"failed to get imx pcie phy clock\n");
245
244
246
245
/* Grab GPR config register range */
247
246
imx8_phy->iomuxc_gpr =
248
247
syscon_regmap_lookup_by_compatible(imx8_phy->drvdata->gpr);
249
-
if (IS_ERR(imx8_phy->iomuxc_gpr)) {
250
-
dev_err(dev, "unable to find iomuxc registers\n");
251
-
return PTR_ERR(imx8_phy->iomuxc_gpr);
252
-
}
248
+
if (IS_ERR(imx8_phy->iomuxc_gpr))
249
+
return dev_err_probe(dev, PTR_ERR(imx8_phy->iomuxc_gpr),
250
+
"unable to find iomuxc registers\n");
253
251
254
252
imx8_phy->reset = devm_reset_control_get_exclusive(dev, "pciephy");
255
-
if (IS_ERR(imx8_phy->reset)) {
256
-
dev_err(dev, "Failed to get PCIEPHY reset control\n");
257
-
return PTR_ERR(imx8_phy->reset);
258
-
}
253
+
if (IS_ERR(imx8_phy->reset))
254
+
return dev_err_probe(dev, PTR_ERR(imx8_phy->reset),
255
+
"Failed to get PCIEPHY reset control\n");
259
256
260
257
if (imx8_phy->drvdata->variant == IMX8MP) {
261
258
imx8_phy->perst =