tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

mm/damon/tests/core-kunit: handle alloc failures on damos_test_filter_out()

damon_test_filter_out() is assuming all dynamic memory allocation in it
will succeed. Those are indeed likely in the real use cases since those
allocations are too small to fail, but theoretically those could fail. In
the case, inappropriate memory access can happen. Fix it by appropriately
cleanup pre-allocated memory and skip the execution of the remaining tests
in the failure cases.

Link: https://lkml.kernel.org/r/20251101182021.74868-16-sj@kernel.org
Fixes: 26713c890875 ("mm/damon/core-test: add a unit test for __damos_filter_out()")
Signed-off-by: SeongJae Park <sj@kernel.org>
Cc: Brendan Higgins <brendan.higgins@linux.dev>
Cc: David Gow <davidgow@google.com>
Cc: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: <stable@vger.kernel.org> [6.6+]
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

authored by

SeongJae Park and committed by
Andrew Morton d14d5671 3e5c4a1a

+11
+11
mm/damon/tests/core-kunit.h
··· 542 542 struct damos_filter *f; 543 543 544 544 f = damos_new_filter(DAMOS_FILTER_TYPE_ADDR, true, false); 545 + if (!f) 546 + kunit_skip(test, "filter alloc fail"); 545 547 f->addr_range = (struct damon_addr_range){ 546 548 .start = DAMON_MIN_REGION * 2, .end = DAMON_MIN_REGION * 6}; 547 549 548 550 t = damon_new_target(); 551 + if (!t) { 552 + damos_destroy_filter(f); 553 + kunit_skip(test, "target alloc fail"); 554 + } 549 555 r = damon_new_region(DAMON_MIN_REGION * 3, DAMON_MIN_REGION * 5); 556 + if (!r) { 557 + damos_destroy_filter(f); 558 + damon_free_target(t); 559 + kunit_skip(test, "region alloc fail"); 560 + } 550 561 damon_add_region(r, t); 551 562 552 563 /* region in the range */