tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

Revert "phy: qcom-qusb2: add QUSB2 support for IPQ5424"

With the current settings, compliance tests especially eye diagram
(Host High-speed Signal Quality) tests are failing. Reuse the IPQ6018
settings to overcome this issue, as mentioned in the Hardware Design
Document.

So revert the change which introduced the new settings and reuse the
IPQ6018 settings in the subsequent patch.

Fixes: 9c56a1de296e ("phy: qcom-qusb2: add QUSB2 support for IPQ5424")
Signed-off-by: Kathiravan Thirumoorthy <kathiravan.thirumoorthy@oss.qualcomm.com>
Link: https://lore.kernel.org/r/20250415-revert_hs_phy_settings-v3-1-3a8f86211b59@oss.qualcomm.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Kathiravan Thirumoorthy and committed by
Vinod Koul 8a040e13 74c2524a

-28
-28
drivers/phy/qualcomm/phy-qcom-qusb2.c
··· 151 151 QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9F), 152 152 }; 153 153 154 - static const struct qusb2_phy_init_tbl ipq5424_init_tbl[] = { 155 - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL, 0x14), 156 - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0x00), 157 - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0x53), 158 - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE4, 0xc3), 159 - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TUNE, 0x30), 160 - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL1, 0x79), 161 - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_USER_CTL2, 0x21), 162 - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE5, 0x00), 163 - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_PWR_CTRL, 0x00), 164 - QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TEST2, 0x14), 165 - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_TEST, 0x80), 166 - QUSB2_PHY_INIT_CFG(QUSB2PHY_PLL_AUTOPGM_CTL1, 0x9f), 167 - }; 168 - 169 154 static const struct qusb2_phy_init_tbl qcs615_init_tbl[] = { 170 155 QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE1, 0xc8), 171 156 QUSB2_PHY_INIT_CFG_L(QUSB2PHY_PORT_TUNE2, 0xb3), ··· 341 356 .disable_ctrl = POWER_DOWN, 342 357 .mask_core_ready = PLL_LOCKED, 343 358 /* autoresume not used */ 344 - .autoresume_en = BIT(0), 345 - }; 346 - 347 - static const struct qusb2_phy_cfg ipq5424_phy_cfg = { 348 - .tbl = ipq5424_init_tbl, 349 - .tbl_num = ARRAY_SIZE(ipq5424_init_tbl), 350 - .regs = ipq6018_regs_layout, 351 - 352 - .disable_ctrl = POWER_DOWN, 353 - .mask_core_ready = PLL_LOCKED, 354 359 .autoresume_en = BIT(0), 355 360 }; 356 361 ··· 929 954 930 955 static const struct of_device_id qusb2_phy_of_match_table[] = { 931 956 { 932 - .compatible = "qcom,ipq5424-qusb2-phy", 933 - .data = &ipq5424_phy_cfg, 934 - }, { 935 957 .compatible = "qcom,ipq6018-qusb2-phy", 936 958 .data = &ipq6018_phy_cfg, 937 959 }, {