Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

platform/surface: surface3-wmi: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new() which already returns void. Eventually after all drivers
are converted, .remove_new() is renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Link: https://lore.kernel.org/r/20230917203805.1149595-2-u.kleine-koenig@pengutronix.de
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>

authored by

Uwe Kleine-König and committed by
Hans de Goede
8d53109d 45ae16ec

+2 -3
+2 -3
drivers/platform/surface/surface3-wmi.c
··· 226 226 return error; 227 227 } 228 228 229 - static int s3_wmi_remove(struct platform_device *device) 229 + static void s3_wmi_remove(struct platform_device *device) 230 230 { 231 231 /* remove the hotplug context from the acpi device */ 232 232 s3_wmi.touchscreen_adev->hp = NULL; 233 233 234 234 /* reinstall the actual PNPC0C0D LID default handle */ 235 235 acpi_bus_scan(s3_wmi.pnp0c0d_adev->handle); 236 - return 0; 237 236 } 238 237 239 238 static int __maybe_unused s3_wmi_resume(struct device *dev) ··· 247 248 .name = "surface3-wmi", 248 249 .pm = &s3_wmi_pm, 249 250 }, 250 - .remove = s3_wmi_remove, 251 + .remove_new = s3_wmi_remove, 251 252 }; 252 253 253 254 static int __init s3_wmi_init(void)