tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

scsi: bnx2i: Replace all non-returning strlcpy with strscpy

strlcpy() reads the entire source buffer first.
This read may exceed the destination size limit.
This is both inefficient and can lead to linear read
overflows if a source string is not NUL-terminated [1].
In an effort to remove strlcpy() completely [2], replace
strlcpy() here with strscpy().
No return values were used, so direct replacement is safe.

[1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy
[2] https://github.com/KSPP/linux/issues/89

Signed-off-by: Azeem Shaikh <azeemshaikh38@gmail.com>
Reviewed-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20230517143130.1519941-1-azeemshaikh38@gmail.com

authored by

Azeem Shaikh and committed by
Kees Cook 8d82557e 2f4113b3

+1 -1
+1 -1
drivers/scsi/bnx2i/bnx2i_init.c
··· 383 383 if (!stats) 384 384 return -ENOMEM; 385 385 386 - strlcpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version)); 386 + strscpy(stats->version, DRV_MODULE_VERSION, sizeof(stats->version)); 387 387 memcpy(stats->mac_add1 + 2, hba->cnic->mac_addr, ETH_ALEN); 388 388 389 389 stats->max_frame_size = hba->netdev->mtu;