tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

media: ipu-bridge: Improve error logging when waiting for IVSC to become ready

The ipu-bridge code waits for the IVSC to become ready (on platforms with
an IVSC chip).

It does this by returning -EPROBE_DEFER, but it does not use
dev_err_probe() so no reason for deferring gets registered.

After 30 seconds the kernel logs a warning that the probe is still
deferred, which looks like this:

[ 33.951709] pci 0000:00:14.3: deferred probe pending: (reason unknown)

Use dev_err_probe() when returning -EPROBE_DEFER to register the probe
deferral reason changing the error to:

deferred probe pending: waiting for IVSC to become ready

to help with debugging why drivers are not binding if the iVSC does
not become ready for some reason.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Signed-off-by: Hans Verkuil <hverkuil@xs4all.nl>

authored by

Hans de Goede and committed by
Hans Verkuil 9316e398 fabb0595

+2 -1
+2 -1
drivers/media/pci/intel/ipu-bridge.c
··· 815 815 return 0; 816 816 817 817 if (!ipu_bridge_ivsc_is_ready()) 818 - return -EPROBE_DEFER; 818 + return dev_err_probe(dev, -EPROBE_DEFER, 819 + "waiting for IVSC to become ready\n"); 819 820 820 821 bridge = kzalloc(sizeof(*bridge), GFP_KERNEL); 821 822 if (!bridge)