Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog: stmp3xxx_rtc: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20230303213716.2123717-34-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Uwe Kleine-König and committed by
Wim Van Sebroeck
96c6e56d e7a84d45

+2 -3
+2 -3
drivers/watchdog/stmp3xxx_rtc_wdt.c
··· 109 109 return 0; 110 110 } 111 111 112 - static int stmp3xxx_wdt_remove(struct platform_device *pdev) 112 + static void stmp3xxx_wdt_remove(struct platform_device *pdev) 113 113 { 114 114 unregister_reboot_notifier(&wdt_notifier); 115 - return 0; 116 115 } 117 116 118 117 static int __maybe_unused stmp3xxx_wdt_suspend(struct device *dev) ··· 143 144 .pm = &stmp3xxx_wdt_pm_ops, 144 145 }, 145 146 .probe = stmp3xxx_wdt_probe, 146 - .remove = stmp3xxx_wdt_remove, 147 + .remove_new = stmp3xxx_wdt_remove, 147 148 }; 148 149 module_platform_driver(stmp3xxx_wdt_driver); 149 150