Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: ti: phy-twl4030-usb: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-32-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul
a01c9d19 c29d4257

+2 -4
+2 -4
drivers/phy/ti/phy-twl4030-usb.c
··· 787 787 return 0; 788 788 } 789 789 790 - static int twl4030_usb_remove(struct platform_device *pdev) 790 + static void twl4030_usb_remove(struct platform_device *pdev) 791 791 { 792 792 struct twl4030_usb *twl = platform_get_drvdata(pdev); 793 793 int val; ··· 821 821 822 822 /* disable complete OTG block */ 823 823 twl4030_usb_clear_bits(twl, POWER_CTRL, POWER_CTRL_OTG_ENAB); 824 - 825 - return 0; 826 824 } 827 825 828 826 #ifdef CONFIG_OF ··· 833 835 834 836 static struct platform_driver twl4030_usb_driver = { 835 837 .probe = twl4030_usb_probe, 836 - .remove = twl4030_usb_remove, 838 + .remove_new = twl4030_usb_remove, 837 839 .driver = { 838 840 .name = "twl4030_usb", 839 841 .pm = &twl4030_usb_pm_ops,