tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

phy: ti: phy-ti-pipe3: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Link: https://lore.kernel.org/r/20230307115900.2293120-31-u.kleine-koenig@pengutronix.de
Signed-off-by: Vinod Koul <vkoul@kernel.org>

authored by

Uwe Kleine-König and committed by
Vinod Koul c29d4257 5566da71

+2 -4
+2 -4
drivers/phy/ti/phy-ti-pipe3.c
··· 841 841 return PTR_ERR_OR_ZERO(phy_provider); 842 842 } 843 843 844 - static int ti_pipe3_remove(struct platform_device *pdev) 844 + static void ti_pipe3_remove(struct platform_device *pdev) 845 845 { 846 846 struct ti_pipe3 *phy = platform_get_drvdata(pdev); 847 847 ··· 850 850 phy->sata_refclk_enabled = false; 851 851 } 852 852 pm_runtime_disable(&pdev->dev); 853 - 854 - return 0; 855 853 } 856 854 857 855 static int ti_pipe3_enable_clocks(struct ti_pipe3 *phy) ··· 926 928 927 929 static struct platform_driver ti_pipe3_driver = { 928 930 .probe = ti_pipe3_probe, 929 - .remove = ti_pipe3_remove, 931 + .remove_new = ti_pipe3_remove, 930 932 .driver = { 931 933 .name = "ti-pipe3", 932 934 .of_match_table = ti_pipe3_id_table,