tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

spi: sh-msiof: Correct SIMDR2_GRPMASK

The Group Output Mask is not a single bit, but a bit field, containing
one bit for each of the four possible groups. Correct the definition.

Note that this change has no direct impact, as the driver only uses
the first group.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Link: https://patch.msgid.link/ad268d67807cb7e544eddaf7a056793482a965d4.1747401908.git.geert+renesas@glider.be
Signed-off-by: Mark Brown <broonie@kernel.org>

authored by

Geert Uytterhoeven and committed by
Mark Brown acedbff0 8f3903b3

+2 -2
+2 -2
drivers/spi/spi-sh-msiof.c
··· 102 102 /* SITMDR2 and SIRMDR2 */ 103 103 #define SIMDR2_BITLEN1 GENMASK(28, 24) /* Data Size (8-32 bits) */ 104 104 #define SIMDR2_WDLEN1 GENMASK(23, 16) /* Word Count (1-64/256 (SH, A1))) */ 105 - #define SIMDR2_GRPMASK1 BIT(0) /* Group Output Mask 1 (SH, A1) */ 105 + #define SIMDR2_GRPMASK GENMASK(3, 0) /* Group Output Mask 1-4 (SH, A1) */ 106 106 107 107 /* SITSCR and SIRSCR */ 108 108 #define SISCR_BRPS GENMASK(12, 8) /* Prescaler Setting (1-32) */ ··· 400 400 if (tx_buf || (p->ctlr->flags & SPI_CONTROLLER_MUST_TX)) 401 401 sh_msiof_write(p, SITMDR2, dr2); 402 402 else 403 - sh_msiof_write(p, SITMDR2, dr2 | SIMDR2_GRPMASK1); 403 + sh_msiof_write(p, SITMDR2, dr2 | SIMDR2_GRPMASK); 404 404 405 405 if (rx_buf) 406 406 sh_msiof_write(p, SIRMDR2, dr2);