Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/amdgpu/mmhub3.0: add bounds checking for cid
The value should never exceed the array size as those
are the only values the hardware is expected to return,
but add checks anyway.
Reviewed-by: Benjamin Cheng <benjamin.cheng@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
(cherry picked from commit f14f27bbe2a3ed7af32d5f6eaf3f417139f45253)
Cc: stable@vger.kernel.org
+2
-1
+2
-1
drivers/gpu/drm/amd/amdgpu/mmhub_v3_0.c
+2
-1
drivers/gpu/drm/amd/amdgpu/mmhub_v3_0.c
···
110
110
switch (amdgpu_ip_version(adev, MMHUB_HWIP, 0)) {
111
111
case IP_VERSION(3, 0, 0):
112
112
case IP_VERSION(3, 0, 1):
113
-
mmhub_cid = mmhub_client_ids_v3_0_0[cid][rw];
113
+
mmhub_cid = cid < ARRAY_SIZE(mmhub_client_ids_v3_0_0) ?
114
+
mmhub_client_ids_v3_0_0[cid][rw] : NULL;
114
115
break;
115
116
default:
116
117
mmhub_cid = NULL;