Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

watchdog: txx9wdt: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.

To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20231106154807.3866712-6-u.kleine-koenig@pengutronix.de
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>

authored by

Uwe Kleine-König and committed by
Wim Van Sebroeck
da241187 2faef275

+2 -3
+2 -3
drivers/watchdog/txx9wdt.c
··· 145 145 return ret; 146 146 } 147 147 148 - static int txx9wdt_remove(struct platform_device *dev) 148 + static void txx9wdt_remove(struct platform_device *dev) 149 149 { 150 150 watchdog_unregister_device(&txx9wdt); 151 151 clk_disable_unprepare(txx9_imclk); 152 152 clk_put(txx9_imclk); 153 - return 0; 154 153 } 155 154 156 155 static void txx9wdt_shutdown(struct platform_device *dev) ··· 159 160 160 161 static struct platform_driver txx9wdt_driver = { 161 162 .probe = txx9wdt_probe, 162 - .remove = txx9wdt_remove, 163 + .remove_new = txx9wdt_remove, 163 164 .shutdown = txx9wdt_shutdown, 164 165 .driver = { 165 166 .name = "txx9wdt",