tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

wifi: mac80211: fix channel switching code

My prior commit here introduced a bug due to copy/paste,
it was iterating the links assigned to 'ctx->replace_ctx'
and I replaced it by iterating links assigned to 'ctx' by
accident, then modified it for the iteration later.

Fix it to iterate the users of the correct chanctx, i.e.
'ctx->replace_ctx'.

Ultimately, this issue led to a crash in a hwsim test
(multi_ap_wps_shared_apdev_csa) because it would actually
do the switch (rather than refuse here) and then later
have a double-free of the original chanctx, because it
was still in use by another interface yet freed as part
of the switching.

Fixes: a1dc648aa76d ("wifi: mac80211: remove chanctx to link back-references")
Link: https://patch.msgid.link/20251121113733.7710a58d45eb.Ie9ec010b52b1baed93dbe44f968c2119b6b5d98d@changeid
Signed-off-by: Johannes Berg <johannes.berg@intel.com>

Johannes Berg de3c5142 49a9feaf

+1 -1
+1 -1
net/mac80211/chan.c
··· 1715 1715 n_reserved = 0; 1716 1716 n_ready = 0; 1717 1717 1718 - for_each_chanctx_user_assigned(local, ctx, &iter) { 1718 + for_each_chanctx_user_assigned(local, ctx->replace_ctx, &iter) { 1719 1719 n_assigned++; 1720 1720 if (iter.link->reserved_chanctx) { 1721 1721 n_reserved++;