Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
ALSA: aoa: Remove redundant size arguments from strscpy()
The size parameter of strscpy() is optional if the destination buffer
has a fixed length and strscpy() can automatically determine its size
using sizeof(). This makes many explicit size arguments redundant.
Remove them to shorten and simplify the code.
No functional changes intended.
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
authored by
Thorsten Blum
and committed by
Takashi Iwai
e135eeef
3c30d575
+10
-13
+1
-1
sound/aoa/codecs/onyx.c
+1
-1
sound/aoa/codecs/onyx.c
+1
-1
sound/aoa/codecs/tas.c
+1
-1
sound/aoa/codecs/tas.c
···
857
857
/* seems that half is a saner default */
858
858
tas->drc_range = TAS3004_DRC_MAX / 2;
859
859
860
-
strscpy(tas->codec.name, "tas", MAX_CODEC_NAME_LEN);
860
+
strscpy(tas->codec.name, "tas");
861
861
tas->codec.owner = THIS_MODULE;
862
862
tas->codec.init = tas_init_codec;
863
863
tas->codec.exit = tas_exit_codec;
+1
-1
sound/aoa/codecs/toonie.c
+1
-1
sound/aoa/codecs/toonie.c
···
126
126
if (!toonie)
127
127
return -ENOMEM;
128
128
129
-
strscpy(toonie->codec.name, "toonie", sizeof(toonie->codec.name));
129
+
strscpy(toonie->codec.name, "toonie");
130
130
toonie->codec.owner = THIS_MODULE;
131
131
toonie->codec.init = toonie_init_codec;
132
132
toonie->codec.exit = toonie_exit_codec;
+4
-4
sound/aoa/core/alsa.c
+4
-4
sound/aoa/core/alsa.c
···
28
28
return err;
29
29
aoa_card = alsa_card->private_data;
30
30
aoa_card->alsa_card = alsa_card;
31
-
strscpy(alsa_card->driver, "AppleOnbdAudio", sizeof(alsa_card->driver));
32
-
strscpy(alsa_card->shortname, name, sizeof(alsa_card->shortname));
33
-
strscpy(alsa_card->longname, name, sizeof(alsa_card->longname));
34
-
strscpy(alsa_card->mixername, name, sizeof(alsa_card->mixername));
31
+
strscpy(alsa_card->driver, "AppleOnbdAudio");
32
+
strscpy(alsa_card->shortname, name);
33
+
strscpy(alsa_card->longname, name);
34
+
strscpy(alsa_card->mixername, name);
35
35
err = snd_card_register(aoa_card->alsa_card);
36
36
if (err < 0) {
37
37
printk(KERN_ERR "snd-aoa: couldn't register alsa card\n");
+3
-6
sound/aoa/fabrics/layout.c
+3
-6
sound/aoa/fabrics/layout.c
···
949
949
ldev->gpio.methods->set_lineout(codec->gpio, 1);
950
950
ctl = snd_ctl_new1(&lineout_ctl, codec->gpio);
951
951
if (cc->connected & CC_LINEOUT_LABELLED_HEADPHONE)
952
-
strscpy(ctl->id.name,
953
-
"Headphone Switch", sizeof(ctl->id.name));
952
+
strscpy(ctl->id.name, "Headphone Switch");
954
953
ldev->lineout_ctrl = ctl;
955
954
aoa_snd_ctl_add(ctl);
956
955
ldev->have_lineout_detect =
···
963
964
ldev);
964
965
if (cc->connected & CC_LINEOUT_LABELLED_HEADPHONE)
965
966
strscpy(ctl->id.name,
966
-
"Headphone Detect Autoswitch",
967
-
sizeof(ctl->id.name));
967
+
"Headphone Detect Autoswitch");
968
968
aoa_snd_ctl_add(ctl);
969
969
ctl = snd_ctl_new1(&lineout_detected,
970
970
ldev);
971
971
if (cc->connected & CC_LINEOUT_LABELLED_HEADPHONE)
972
972
strscpy(ctl->id.name,
973
-
"Headphone Detected",
974
-
sizeof(ctl->id.name));
973
+
"Headphone Detected");
975
974
ldev->lineout_detected_ctrl = ctl;
976
975
aoa_snd_ctl_add(ctl);
977
976
}