tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/msm/a6xx: move preempt_prepare_postamble after error check

Move the call to preempt_prepare_postamble() after verifying that
preempt_postamble_ptr is valid. If preempt_postamble_ptr is NULL,
dereferencing it in preempt_prepare_postamble() would lead to a crash.

This change avoids calling the preparation function when the
postamble allocation has failed, preventing potential NULL pointer
dereference and ensuring proper error handling.

Fixes: 50117cad0c50 ("drm/msm/a6xx: Use posamble to reset counters on preemption")
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Patchwork: https://patchwork.freedesktop.org/patch/687659/
Message-ID: <20251113082839.3821867-1-alok.a.tiwari@oracle.com>
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>

authored by

Alok Tiwari and committed by
Rob Clark ef3b0409 129049d4

+2 -2
+2 -2
drivers/gpu/drm/msm/adreno/a6xx_preempt.c
··· 454 454 gpu->vm, &a6xx_gpu->preempt_postamble_bo, 455 455 &a6xx_gpu->preempt_postamble_iova); 456 456 457 - preempt_prepare_postamble(a6xx_gpu); 458 - 459 457 if (IS_ERR(a6xx_gpu->preempt_postamble_ptr)) 460 458 goto fail; 459 + 460 + preempt_prepare_postamble(a6xx_gpu); 461 461 462 462 timer_setup(&a6xx_gpu->preempt_timer, a6xx_preempt_timer, 0); 463 463