tjh.dev / kernel
Linux kernel mirror (for testing) git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel os linux
1
fork

Configure Feed

Select the types of activity you want to include in your feed.

drm/msm/dpu: dpu_hw_sspp.h: fix all kernel-doc warnings

Modify non-kernel-doc comments to begin with "/*" instead of "/**".
Correct or add kernel-doc comments to eliminate all warnings:

Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:17 missing initial
short description on line: * Flags
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:19 expecting
prototype for Flags(). Prototype was for DPU_SSPP_FLIP_LR() instead
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:26 This comment
starts with '/**', but isn't a kernel-doc comment.
* Component indices
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:47 cannot understand
function prototype: 'enum dpu_sspp_multirect_index'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:152 struct member
'dst_rect' not described in 'dpu_sw_pipe_cfg'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:174 struct member
'multirect_index' not described in 'dpu_sw_pipe'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:174 struct member
'multirect_mode' not described in 'dpu_sw_pipe'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:183 Incorrect use of
kernel-doc format: * setup_format - setup pixel format cropping
rectangle, flip
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:192 Incorrect use of
kernel-doc format: * setup_rects - setup pipe ROI rectangles
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:200 Incorrect use of
kernel-doc format: * setup_pe - setup pipe pixel extension
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:208 Incorrect use of
kernel-doc format: * setup_sourceaddress - setup pipe source addresses
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:216 Incorrect use of
kernel-doc format: * setup_csc - setup color space coversion
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:223 Incorrect use of
kernel-doc format: * setup_solidfill - enable/disable colorfill
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:231 Incorrect use of
kernel-doc format: * setup_multirect - setup multirect configuration
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:238 Incorrect use of
kernel-doc format: * setup_sharpening - setup sharpening
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:247 Incorrect use of
kernel-doc format: * setup_qos_lut - setup QoS LUTs
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:255 Incorrect use of
kernel-doc format: * setup_qos_ctrl - setup QoS control
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:263 Incorrect use of
kernel-doc format: * setup_clk_force_ctrl - setup clock force control
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:271 Incorrect use of
kernel-doc format: * setup_histogram - setup histograms
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:279 Incorrect use of
kernel-doc format: * setup_scaler - setup scaler
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:288 Incorrect use of
kernel-doc format: * setup_cdp - setup client driven prefetch
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_format' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_rects' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_pe' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_sourceaddress' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_csc' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_solidfill' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_multirect' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_sharpening' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_qos_lut' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_qos_ctrl' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_clk_force_ctrl' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_histogram' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_scaler' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:296 struct member
'setup_cdp' not described in 'dpu_hw_sspp_ops'
Warning: drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h:320 struct member
'mdss_ver' not described in 'dpu_hw_sspp'

Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Patchwork: https://patchwork.freedesktop.org/patch/695661/
Link: https://lore.kernel.org/r/20251219184638.1813181-13-rdunlap@infradead.org
Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

authored by

Randy Dunlap and committed by
Dmitry Baryshkov f5a7145d abc287a7

+24 -23
+24 -23
drivers/gpu/drm/msm/disp/dpu1/dpu_hw_sspp.h
··· 14 14 15 15 #define DPU_SSPP_MAX_PITCH_SIZE 0xffff 16 16 17 - /** 17 + /* 18 18 * Flags 19 19 */ 20 20 #define DPU_SSPP_FLIP_LR BIT(0) ··· 23 23 #define DPU_SSPP_ROT_90 BIT(3) 24 24 #define DPU_SSPP_SOLID_FILL BIT(4) 25 25 26 - /** 26 + /* 27 27 * Component indices 28 28 */ 29 29 enum { ··· 36 36 }; 37 37 38 38 /** 39 - * DPU_SSPP_RECT_SOLO - multirect disabled 40 - * DPU_SSPP_RECT_0 - rect0 of a multirect pipe 41 - * DPU_SSPP_RECT_1 - rect1 of a multirect pipe 39 + * enum dpu_sspp_multirect_index - multirect mode 40 + * @DPU_SSPP_RECT_SOLO: multirect disabled 41 + * @DPU_SSPP_RECT_0: rect0 of a multirect pipe 42 + * @DPU_SSPP_RECT_1: rect1 of a multirect pipe 42 43 * 43 44 * Note: HW supports multirect with either RECT0 or 44 45 * RECT1. Considering no benefit of such configs over ··· 144 143 * struct dpu_sw_pipe_cfg : software pipe configuration 145 144 * @src_rect: src ROI, caller takes into account the different operations 146 145 * such as decimation, flip etc to program this field 147 - * @dest_rect: destination ROI. 146 + * @dst_rect: destination ROI. 148 147 * @rotation: simplified drm rotation hint 149 148 */ 150 149 struct dpu_sw_pipe_cfg { ··· 166 165 /** 167 166 * struct dpu_sw_pipe - software pipe description 168 167 * @sspp: backing SSPP pipe 169 - * @index: index of the rectangle of SSPP 170 - * @mode: parallel or time multiplex multirect mode 168 + * @multirect_index: index of the rectangle of SSPP 169 + * @multirect_mode: parallel or time multiplex multirect mode 171 170 */ 172 171 struct dpu_sw_pipe { 173 172 struct dpu_hw_sspp *sspp; ··· 182 181 */ 183 182 struct dpu_hw_sspp_ops { 184 183 /** 185 - * setup_format - setup pixel format cropping rectangle, flip 184 + * @setup_format: setup pixel format cropping rectangle, flip 186 185 * @pipe: Pointer to software pipe context 187 186 * @cfg: Pointer to pipe config structure 188 187 * @flags: Extra flags for format config ··· 191 190 const struct msm_format *fmt, u32 flags); 192 191 193 192 /** 194 - * setup_rects - setup pipe ROI rectangles 193 + * @setup_rects: setup pipe ROI rectangles 195 194 * @pipe: Pointer to software pipe context 196 195 * @cfg: Pointer to pipe config structure 197 196 */ ··· 199 198 struct dpu_sw_pipe_cfg *cfg); 200 199 201 200 /** 202 - * setup_pe - setup pipe pixel extension 201 + * @setup_pe: setup pipe pixel extension 203 202 * @ctx: Pointer to pipe context 204 203 * @pe_ext: Pointer to pixel ext settings 205 204 */ ··· 207 206 struct dpu_hw_pixel_ext *pe_ext); 208 207 209 208 /** 210 - * setup_sourceaddress - setup pipe source addresses 209 + * @setup_sourceaddress: setup pipe source addresses 211 210 * @pipe: Pointer to software pipe context 212 211 * @layout: format layout information for programming buffer to hardware 213 212 */ ··· 215 214 struct dpu_hw_fmt_layout *layout); 216 215 217 216 /** 218 - * setup_csc - setup color space coversion 217 + * @setup_csc: setup color space coversion 219 218 * @ctx: Pointer to pipe context 220 219 * @data: Pointer to config structure 221 220 */ 222 221 void (*setup_csc)(struct dpu_hw_sspp *ctx, const struct dpu_csc_cfg *data); 223 222 224 223 /** 225 - * setup_solidfill - enable/disable colorfill 224 + * @setup_solidfill: enable/disable colorfill 226 225 * @pipe: Pointer to software pipe context 227 226 * @const_color: Fill color value 228 227 * @flags: Pipe flags ··· 230 229 void (*setup_solidfill)(struct dpu_sw_pipe *pipe, u32 color); 231 230 232 231 /** 233 - * setup_multirect - setup multirect configuration 232 + * @setup_multirect: setup multirect configuration 234 233 * @pipe: Pointer to software pipe context 235 234 */ 236 235 237 236 void (*setup_multirect)(struct dpu_sw_pipe *pipe); 238 237 239 238 /** 240 - * setup_sharpening - setup sharpening 239 + * @setup_sharpening: setup sharpening 241 240 * @ctx: Pointer to pipe context 242 241 * @cfg: Pointer to config structure 243 242 */ 244 243 void (*setup_sharpening)(struct dpu_hw_sspp *ctx, 245 244 struct dpu_hw_sharp_cfg *cfg); 246 245 247 - 248 246 /** 249 - * setup_qos_lut - setup QoS LUTs 247 + * @setup_qos_lut: setup QoS LUTs 250 248 * @ctx: Pointer to pipe context 251 249 * @cfg: LUT configuration 252 250 */ ··· 253 253 struct dpu_hw_qos_cfg *cfg); 254 254 255 255 /** 256 - * setup_qos_ctrl - setup QoS control 256 + * @setup_qos_ctrl: setup QoS control 257 257 * @ctx: Pointer to pipe context 258 258 * @danger_safe_en: flags controlling enabling of danger/safe QoS/LUT 259 259 */ ··· 261 261 bool danger_safe_en); 262 262 263 263 /** 264 - * setup_clk_force_ctrl - setup clock force control 264 + * @setup_clk_force_ctrl: setup clock force control 265 265 * @ctx: Pointer to pipe context 266 266 * @enable: enable clock force if true 267 267 */ ··· 269 269 bool enable); 270 270 271 271 /** 272 - * setup_histogram - setup histograms 272 + * @setup_histogram: setup histograms 273 273 * @ctx: Pointer to pipe context 274 274 * @cfg: Pointer to histogram configuration 275 275 */ ··· 277 277 void *cfg); 278 278 279 279 /** 280 - * setup_scaler - setup scaler 280 + * @setup_scaler: setup scaler 281 281 * @scaler3_cfg: Pointer to scaler configuration 282 282 * @format: pixel format parameters 283 283 */ ··· 286 286 const struct msm_format *format); 287 287 288 288 /** 289 - * setup_cdp - setup client driven prefetch 289 + * @setup_cdp: setup client driven prefetch 290 290 * @pipe: Pointer to software pipe context 291 291 * @fmt: format used by the sw pipe 292 292 * @enable: whether the CDP should be enabled for this pipe ··· 303 303 * @ubwc: UBWC configuration data 304 304 * @idx: pipe index 305 305 * @cap: pointer to layer_cfg 306 + * @mdss_ver: MDSS version info to use for feature checks 306 307 * @ops: pointer to operations possible for this pipe 307 308 */ 308 309 struct dpu_hw_sspp {