Linux kernel mirror (for testing)
git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
kernel
os
linux
drm/msm: Improve msm_context comments
Just some tidying up.
Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
Signed-off-by: Rob Clark <robin.clark@oss.qualcomm.com>
Tested-by: Antonino Maniscalco <antomani103@gmail.com>
Reviewed-by: Antonino Maniscalco <antomani103@gmail.com>
Patchwork: https://patchwork.freedesktop.org/patch/661461/
+29
-15
+29
-15
drivers/gpu/drm/msm/msm_gpu.h
+29
-15
drivers/gpu/drm/msm/msm_gpu.h
···
342
342
343
343
/**
344
344
* struct msm_context - per-drm_file context
345
-
*
346
-
* @queuelock: synchronizes access to submitqueues list
347
-
* @submitqueues: list of &msm_gpu_submitqueue created by userspace
348
-
* @queueid: counter incremented each time a submitqueue is created,
349
-
* used to assign &msm_gpu_submitqueue.id
350
-
* @aspace: the per-process GPU address-space
351
-
* @ref: reference count
352
-
* @seqno: unique per process seqno
353
345
*/
354
346
struct msm_context {
347
+
/** @queuelock: synchronizes access to submitqueues list */
355
348
rwlock_t queuelock;
349
+
350
+
/** @submitqueues: list of &msm_gpu_submitqueue created by userspace */
356
351
struct list_head submitqueues;
352
+
353
+
/**
354
+
* @queueid:
355
+
*
356
+
* Counter incremented each time a submitqueue is created, used to
357
+
* assign &msm_gpu_submitqueue.id
358
+
*/
357
359
int queueid;
360
+
361
+
/** @aspace: the per-process GPU address-space */
358
362
struct msm_gem_address_space *aspace;
363
+
364
+
/** @kref: the reference count */
359
365
struct kref ref;
366
+
367
+
/**
368
+
* @seqno:
369
+
*
370
+
* A unique per-process sequence number. Used to detect context
371
+
* switches, without relying on keeping a, potentially dangling,
372
+
* pointer to the previous context.
373
+
*/
360
374
int seqno;
361
375
362
376
/**
363
-
* sysprof:
377
+
* @sysprof:
364
378
*
365
379
* The value of MSM_PARAM_SYSPROF set by userspace. This is
366
380
* intended to be used by system profiling tools like Mesa's
···
392
378
int sysprof;
393
379
394
380
/**
395
-
* comm: Overridden task comm, see MSM_PARAM_COMM
381
+
* @comm: Overridden task comm, see MSM_PARAM_COMM
396
382
*
397
383
* Accessed under msm_gpu::lock
398
384
*/
399
385
char *comm;
400
386
401
387
/**
402
-
* cmdline: Overridden task cmdline, see MSM_PARAM_CMDLINE
388
+
* @cmdline: Overridden task cmdline, see MSM_PARAM_CMDLINE
403
389
*
404
390
* Accessed under msm_gpu::lock
405
391
*/
406
392
char *cmdline;
407
393
408
394
/**
409
-
* elapsed:
395
+
* @elapsed:
410
396
*
411
397
* The total (cumulative) elapsed time GPU was busy with rendering
412
398
* from this context in ns.
···
414
400
uint64_t elapsed_ns;
415
401
416
402
/**
417
-
* cycles:
403
+
* @cycles:
418
404
*
419
405
* The total (cumulative) GPU cycles elapsed attributed to this
420
406
* context.
···
422
408
uint64_t cycles;
423
409
424
410
/**
425
-
* entities:
411
+
* @entities:
426
412
*
427
413
* Table of per-priority-level sched entities used by submitqueues
428
414
* associated with this &drm_file. Because some userspace apps
···
435
421
struct drm_sched_entity *entities[NR_SCHED_PRIORITIES * MSM_GPU_MAX_RINGS];
436
422
437
423
/**
438
-
* ctx_mem:
424
+
* @ctx_mem:
439
425
*
440
426
* Total amount of memory of GEM buffers with handles attached for
441
427
* this context.